chore: delete useless buffered activation #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! This is the bug that caused a lot of memory issues with QLoRA. I cannot believe I missed this bug for such a long time. This will very significantly reduce the memory footprint of QLoRA fine-tuning with larger batch sizes or longer sequence lengths. Thank you! |
Titus-von-Koeller
merged commit 9e75374
into
bitsandbytes-foundation:main
8 of 21 checks passed
|
Thank you so much for this extremely helpful contribution, @Ther-nullptr ! Saw your repo and this commit, really interesting! Please tag me if there's anything else we can help you with in that effort. Release with this fix just went live! |
|
I'm quite new to qlora's repo, what is the |
8 tasks
matthewdouglas
pushed a commit
to matthewdouglas/bitsandbytes
that referenced
this pull request
Oct 28, 2024
…oundation#1270) * chore: delete useless buffered activation * fix: fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For QLoRA models, we do not need to update the$\mathbf{W}$ , so the buffered activation of $\mathbf{A}$ is useless. It is suggested not to save $\mathbf{A}$ in
ctxto save the memory.